Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some TileMap dependencies from TileMapLayer #92194

Merged
merged 1 commit into from
May 21, 2024
Merged

Remove some TileMap dependencies from TileMapLayer #92194

merged 1 commit into from
May 21, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented May 21, 2024

Moves draw_tile() to TileMapLayer and removes some unnecessary TileMap::s.

@KoBeWi KoBeWi added this to the 4.x milestone May 21, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner May 21, 2024 08:59
@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 21, 2024
@KoBeWi KoBeWi force-pushed the TileMap_is_dead branch from 2c9ed13 to 6559bb6 Compare May 21, 2024 09:32
@akien-mga akien-mga merged commit 7ecf3eb into godotengine:master May 21, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the TileMap_is_dead branch May 21, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@groud groud groud approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@KoBeWi @akien-mga @groud @AThousandShips