Fix 2d sdf collision for TileMapLayer Occluders #92173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #91907 and #92052.
Before this PR went in, the 2d rendering system ignored the sdf collision flag on 2d light occluder instances and always drew light occluder polygons to the sdf texture. Now, occluders aren't drawn to the texture when sdf collision is false.
Apparently,
TileMapand nowTileMapLayerhave both been impacted by this fix, as setting the sdf collision flag for their occlusion layers doesn't actually update the underlying light occluder instance (even though it should). This change fixes that, so now the sdf collision field of aTileMapLayer's occlusion layer dictates whether or not it's drawn to the sdf texture:closes #91907
closes #92052.