OpenXR: Fix updating swapchain for foveation #92137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
force-pushed
the
fix_fb_swapchain_foveation
branch
from
cca6d74 to
6582be0
Compare
dsnopek
reviewed
May 20, 2024
dsnopek
approved these changes
May 21, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With our recent changes around updating the swapchain when resized, we broke the OpenXR foveation logic as we delayed creating swapchains until rendering. This is thus a regression introduced in 4.3 dev6 (compared to dev5).
Also with the added multithreading changes, this code was not thread safe.
This PR fixes both the regression and the safety issue.