Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tree and FileSystemList edit popup double events and ESC behavior. #92042

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix Tree and FileSystemList edit popup double events and ESC behavior. #92042

merged 1 commit into from
May 17, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented May 17, 2024 •
edited
Loading

Fixes #90473

Fixes canceling edit with ESC, popup behavior should now be (I have taken Finder file rename behavior as example, bot sure if all apps be the same):

  • Pressing ESC cancels edit and closes the popup.
  • Pressing Enter applies edit and closes the popup.
  • Clicking outside popup (in the app or on the other app window) applies edit and closes the popup.

TODO - Testing:

  • Single window mode (should be the same on all platforms)
    • On macOS
    • On Windows
    • Linux/X11
    • Linux/Wayland
  • macOS
  • Linux/X11 on X11
  • Linux/X11 on Wayland
  • Windows

@bruvzg bruvzg added this to the 4.3 milestone May 17, 2024
@bruvzg bruvzg marked this pull request as ready for review May 17, 2024 08:30
@bruvzg bruvzg requested review from a team as code owners May 17, 2024 08:30
akien-mga
akien-mga approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on Linux, Fedora 40 KDE on Wayland.
Tested X11 (multi and single window mode) and Wayland (single window mode) display servers.

@akien-mga akien-mga requested review from KoBeWi and RandomShaper May 17, 2024 09:55
@akien-mga akien-mga merged commit 85463fd into godotengine:master May 17, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

@RandomShaper RandomShaper Awaiting requested review from RandomShaper

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Renaming a file sometimes shows an error popup
3 participants
@bruvzg @akien-mga @KoBeWi