Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ContextMenu Copy Error is off in MSBuild Panel #91996

Merged
merged 1 commit into from
May 16, 2024

Conversation

Maran23
Copy link
Contributor

@Maran23 Maran23 commented May 15, 2024

Fixes: #91995

The fix is to do the same thing that is also done for basically every other Popup ContextMenu in Godot.
That is to get the screen position of the Control and add the mouse position to it.

image

@Maran23 Maran23 requested a review from a team as a code owner May 15, 2024 21:04
@raulsntos raulsntos added this to the 4.3 milestone May 16, 2024
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label May 16, 2024
@akien-mga akien-mga merged commit 8663f27 into godotengine:master May 16, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContextMenu Copy Error is off in MSBuild Panel
3 participants