Fix TextEdit caret movement at start of wrapped lines #91978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbdev
force-pushed
the
select_first_wrapped_char
branch
from
b6db4ab to
352c9ed
Compare
|
Rebased to fix conflict. |
kitbdev
changed the title
kitbdev
changed the title
kitbdev
force-pushed
the
select_first_wrapped_char
branch
from
352c9ed to
93a81dd
Compare
akien-mga
approved these changes
Aug 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextServer::shaped_text_*_character_posfor the first character of wrapped string. Allow starting/ending RTL selection before line start. #95301Fixes moving caret to start of wrapped line with up/down moving to after the first character.
Fixes setting last fit at start of wrapped line acting as the end of the previous wrap. This caused the caret to jump to the end of the previous/next line instead of moving straight up or down.
Removed some dead code in
TextEdit::get_line_column_at_pos.Added tests.