-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Re-add Variant class initializer, fix comment #91955
Core: Re-add Variant class initializer, fix comment #91955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but TIWAGOS
c1c5c88
to
2009c79
Compare
It also technically allocates data for the (packed) arrays and dicts, but for static sized data this is correct |
That should still be fine in this context; |
It does exceed that as it allocates a reference to those types, but the size of those depends on pointer sizes and alignment so might be platform dependent, but it does allocate extra data, just not of fixed size, as those data types (including |
2009c79
to
7599a7b
Compare
Ahhh, now I see what you mean. No harm in making that a footnote as well. |
Thanks! |
Fixes two minor issues in
variant.h
:type
(Core: Utilize initializer lists in Variant constructors #90866 regression).