Fix wrong usage of parameters_base_path StringName
#91944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
May 14, 2024
| @@ -626,7 +626,7 @@ bool AnimationTree::_blend_pre_process(double p_delta, int p_track_count, const | |||
| for (int i = 0; i < p_track_count; i++) { | |||
| src_blendsw[i] = 1.0; // By default all go to 1 for the root input. | |||
| } | |||
| root_animation_node->node_state.base_path = SceneStringName(parameters_base_path); | |||
| root_animation_node->node_state.base_path = SNAME(Animation::PARAMETERS_BASE_PATH.ascii().get_data()); | |||
There was a problem hiding this comment.
This should be working correctly, but it would be nice if someone can confirm that this doesn't break anything. SNAME creates a static object, so .ascii().get_data() is done only once.
akien-mga
approved these changes
May 30, 2024
|
Needs rebase. |
KoBeWi
force-pushed
the
even_though_StringName_contains_String_in_its_name,_it's_not_actually_a_String
branch
from
3a3f639 to
a345160
Compare
|
Thanks! |
KoBeWi
deleted the
even_though_StringName_contains_String_in_its_name,_it's_not_actually_a_String
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parameters_base_pathwas registered as a scene string name, but all of its usages, except 1, converted it to String. I changed it to a constant String in Animation and the single StringName usage was converted to SNAME.