-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default parenting behavior when drag-and-dropping to 2d and 3d editor #91874
Change default parenting behavior when drag-and-dropping to 2d and 3d editor #91874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 2D and 3D, looks good. Just needs to fix code style/formatting.
Hoping this makes it in for 4.3, I find the current behavior to be very unintuitive and the justifications in the proposal seem sound.
Yes please to this PR! An excellent UX improvement. |
The formatting should be ok now? Let me know if there are any issues. Edit: In terms of making it for 4.3, I hope this PR can be considered a bug fix, as the current behaviour is accidental from the interaction between 2 different PRs (as explained in the proposal). |
For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. Also while fixing style issues, please make sure to squash the commits into one. |
883fc52
to
5835c27
Compare
I think I fixed eveything you've mentionned 🚀 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks ok.
5835c27
to
f7ba82d
Compare
correct formatting with clang-formatter US English
f7ba82d
to
8e0f0c6
Compare
Thanks! And congrats for your first merged Godot contribution 🎉 |
Implement this proposal: godotengine/godot-proposals#9682
Note: I was thinking to add a
label
andlabel_desc
in the 3D editor as it is in the 2D editor. But I think it might need its own proposal.