Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default parenting behavior when drag-and-dropping to 2d and 3d editor #91874

Merged

Conversation

Nodragem
Copy link
Contributor

@Nodragem Nodragem commented May 12, 2024

Implement this proposal: godotengine/godot-proposals#9682

Note: I was thinking to add a label and label_desc in the 3D editor as it is in the 2D editor. But I think it might need its own proposal.

@Nodragem Nodragem requested a review from a team as a code owner May 12, 2024 13:11
@AThousandShips AThousandShips changed the title change default behaviour when drag-and-drop to 2d and 3d editor Change default parenting behavior when drag-and-dropping to 2d and 3d editor May 12, 2024
@AThousandShips AThousandShips added this to the 4.x milestone May 12, 2024
Copy link
Contributor

@ryevdokimov ryevdokimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 2D and 3D, looks good. Just needs to fix code style/formatting.

Hoping this makes it in for 4.3, I find the current behavior to be very unintuitive and the justifications in the proposal seem sound.

@AdriaandeJongh
Copy link
Contributor

Yes please to this PR! An excellent UX improvement.

@Nodragem
Copy link
Contributor Author

Nodragem commented May 12, 2024

The formatting should be ok now? Let me know if there are any issues.

Edit: In terms of making it for 4.3, I hope this PR can be considered a bug fix, as the current behaviour is accidental from the interaction between 2 different PRs (as explained in the proposal).

@akien-mga akien-mga requested review from Calinou and KoBeWi May 12, 2024 22:32
@akien-mga
Copy link
Member

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.


Also while fixing style issues, please make sure to squash the commits into one.

@Nodragem Nodragem force-pushed the editor-scene-drag-and-drop-default branch from 883fc52 to 5835c27 Compare May 13, 2024 17:30
@Nodragem
Copy link
Contributor Author

I think I fixed eveything you've mentionned 🚀 !

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 16, 2024
@Nodragem Nodragem force-pushed the editor-scene-drag-and-drop-default branch from 5835c27 to f7ba82d Compare May 16, 2024 09:34
correct formatting with clang-formatter

US English
@akien-mga akien-mga merged commit b201c7f into godotengine:master May 17, 2024
16 checks passed
@akien-mga
Copy link
Member

akien-mga commented May 17, 2024

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "add as sibling" the default when drag-and-dropping an asset into 3D View
6 participants