[Web] Fix splash screen background color in HTML shell #91852
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
I would like to propose a small amendment to the new splash screen related to the background color. My first version used #38363A which came from the div #status-progress of the previous splash screen, but to be consistent with other exporters, the correct background color should be the same as the default
application/boot_splash/bg_color
from Project Settings, which is #242424.main/main_builders.py
Difference
Before:
After:
Notes
In the future, it may be possible to pass information to the HTML shell about user settings such as
application/boot_splash/bg_color
orapplication/boot_splash/show_image
. For now, we can add information in the documentation that it is easy to modify the background color by typing CSS in theHead Include
field:Similarly, you can hide the splash image by typing: