Rewrite reprojection for FSR2 to work correctly with Reverse-Z. #91799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does fix the issue, the MVs are no longer messed up with FSR2 |
clayjohn
approved these changes
May 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91758.
The Reverse-Z change broke the motion vector derivation from depth for FSR2. This was more visually obvious by looking at the debug view. The fix seems fairly straightforward: just use the depth correction matrix to fix the projections used in the formula instead of just
flipped_y().Tagging @mrjustaguy who opened the original issue to confirm if this fixes the issue for them.