Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Fix comparison warnings in StringExtensions.cs #91763

Merged

Conversation

paulloz
Copy link
Member

@paulloz paulloz commented May 9, 2024

Follow-up to #91203 that introduced several warnings in StringExtensions.cs.

@paulloz paulloz added this to the 4.3 milestone May 9, 2024
@paulloz paulloz requested a review from a team as a code owner May 9, 2024 13:32
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few minor nit-picks but otherwise it's good.

@paulloz paulloz force-pushed the dotnet/fix-stringextension-warnings branch from 3118aff to af5f695 Compare May 10, 2024 07:43
@akien-mga akien-mga added the bug label May 10, 2024
@akien-mga akien-mga merged commit d24403d into godotengine:master May 10, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@paulloz paulloz deleted the dotnet/fix-stringextension-warnings branch May 10, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants