CommandQueueMT
: Pre-allocate memory to avoid a bunch of allocations at startup
#91727
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an unused
DEFAULT_COMMAND_MEM_SIZE_KB
constant. I've not been able to find if it had ever been used. However, it's not a bad idea to preallocate a bit of memory so the first bunch of commands added to the queue don't cause reallocations. Not a big deal, but very easy to prevent.I've lowered the pre-allocation size constant from 256 KiB to 64 KiB to be a bit more conservative. A lot of commands already fit there and exponential growth will take care of further needs just fine.
Made on top of #91725 because of the conflicts.