Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MinGW] Restore executable size check (reverted) #91698

Merged
merged 1 commit into from
May 8, 2024
Merged

[MinGW] Restore executable size check (reverted) #91698

merged 1 commit into from
May 8, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented May 8, 2024

Restore MinGW executable size check (#79875) broken by #85319

@bruvzg bruvzg added this to the 4.3 milestone May 8, 2024
@bruvzg bruvzg requested a review from a team as a code owner May 8, 2024 08:47
akien-mga
akien-mga approved these changes May 8, 2024
View reviewed changes
platform/windows/platform_windows_builders.py Outdated Show resolved Hide resolved
@bruvzg bruvzg force-pushed the mingw_exe_size branch from 13b8c46 to 15d37ed Compare May 8, 2024 09:43
@akien-mga akien-mga merged commit a7f4860 into godotengine:master May 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request May 9, 2024
Merged
@akien-mga akien-mga changed the title [MinGW] Restore executable size check. [MinGW] Restore executable size check (reverted) May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:buildsystem
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga