Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit icon size in EditorDebuggerTree. #91622

Conversation

Daylily-Zeleen
Copy link
Contributor

@Daylily-Zeleen Daylily-Zeleen commented May 6, 2024

Limit custom classes icon size in EditorDebuggerTree.

Before:
"Remote" Tab:
QQ图片20240506223825
But the scene tree editor can display it correctly.
QQ图片20240506232416

After:
QQ图片20240506232541

@Daylily-Zeleen Daylily-Zeleen requested a review from a team as a code owner May 6, 2024 15:28
@AThousandShips AThousandShips added this to the 4.3 milestone May 6, 2024
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/limit_icon_size_in_EditorDebuggerTree branch from 129dfbe to 4ce62e4 Compare May 7, 2024 05:31
@Daylily-Zeleen
Copy link
Contributor Author

Any progress?

editor/debugger/editor_debugger_tree.cpp Outdated Show resolved Hide resolved
editor/debugger/editor_debugger_tree.cpp Outdated Show resolved Hide resolved
@KoBeWi
Copy link
Member

KoBeWi commented May 24, 2024

How can I test this bug? The linked issue suggests that it's related to GDExtension, but I don't have MRP for Windows at hand.

@Daylily-Zeleen
Copy link
Contributor Author

You can just build godot-cpp's test and add few lines to example.gdextension:

[icons]
Example = "res://icon.png"

Then add return to func _ready() in "main.gd" to avoid auto quit.

Run the "main.tscn" and check the remote scene tree:

QQ截图20240524232110

@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/limit_icon_size_in_EditorDebuggerTree branch 2 times, most recently from 1947d09 to 5a4fe39 Compare May 24, 2024 18:52
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/limit_icon_size_in_EditorDebuggerTree branch from 5a4fe39 to b941459 Compare May 25, 2024 06:13
@akien-mga akien-mga merged commit b0ba8ac into godotengine:master May 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Daylily-Zeleen Daylily-Zeleen deleted the daylily-zeleen/limit_icon_size_in_EditorDebuggerTree branch June 4, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDExtension icons are big in 'Remote' scene tree
6 participants