Replace find with contains/has where applicable

[AThousandShips]

• Replaces find(...) != -1, find(...) > -1, find(...) >= 0 with contains for String
• Replaces find(...) == -1, find(...) < 0 with !contains for String
• Replaces find(...) != -1, find(...) > -1, find(...) >= 0 with has for containers
• Replaces find(...) == -1, find(...) < 0 with !has for containers

Split into four commits for review to make it easier to compare each type, to check the replacements are appropriate

[Chaosus]

Guess this line could be changed too (after d8aa2c6):

godot/editor/connections_dialog.cpp

Line 285 in d8aa2c6

if (!p_search_string.is_empty() && mi.name.findn(p_search_string) == -1) {

[AThousandShips]

That's findn that's different, that's covered here:

• [Core] Add case-insensitive String::containsn #91611

[Riteo]

The diff looks fine and I really appreciate this change!

Thanks for splitting the patch, it really helped with reviewing as I could go in full pattern-matching mode with the word diff.

[akien-mga]

Also looks good to me. I guess we can squash before merge now that it's been reviewed.

[mhilbrunner]

Thank you so much! Spotted nothing.

[akien-mga]

Thanks!

[AThousandShips]

Thank you!