Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web, 3.x] Add IME input support. #91610

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented May 6, 2024

Backport of #79362 (also include #91695 fixes).

@jtakakura
Copy link
Contributor

jtakakura commented May 7, 2024

Thank you for your backport.
It seems to work fine on Firefox.

79362_add_ime_input_support_firefox.mp4

However, upon confirming the Japanese input with the Enter key, a new line is inserted simultaneously on Safari on macOS.

79362_add_ime_input_support_safari.mp4

This could be caused by Safari or Godot; it's not clear which one.

@bruvzg bruvzg force-pushed the web_ime_3 branch 2 times, most recently from e02d9f2 to 7ddf27b Compare May 8, 2024 07:38
@bruvzg
Copy link
Member Author

bruvzg commented May 9, 2024

This could be caused by Safari or Godot; it's not clear which one.

Seems to be something Safari specific, I can't reproduce it in Chrome or Firefox. Also reproducible with Safari and 4.x.

@JunShiozawa
Copy link

How can I check if it works?

@bruvzg bruvzg marked this pull request as ready for review May 14, 2024 17:22
@JunShiozawa
Copy link

@akien-mga
Why don't you review this PR?

@akien-mga
Copy link
Member

@akien-mga Why don't you review this PR?

I would kindly ask you to stop lobbying maintainers to work on your personal priorities. We are all busy and doing what we can with the time we have.

If you absolutely need this PR today, you can merge it in your own branch and use it, following the documentation that was linked to you above.

If you want to help getting this merged, actually testing it and reporting whether it works on all your target browsers would be very helpful.

@JunShiozawa
Copy link

@akien-mga
I am sorry.

@jtakakura
Copy link
Contributor

jtakakura commented May 25, 2024

@JunShiozawa Did you check if it works?
I already explained how to check it.
Will this PR meet your expectations if merged as it is?

@JunShiozawa
Copy link

Where is Export templates?
I can not export HTML5.

@JunShiozawa
Copy link

This for Godot 4.x Version is
Chrome for Android Japanese input OK.
Firefox for Android Japanese input OK.
Safari for iPhone Japanese input OK.
Firefox for Linux Japanese input OK.
Firefox for Windows Japanese input OK.
Probably it will work.

@akien-mga akien-mga modified the milestones: 3.x, 3.6 Jun 25, 2024
@akien-mga
Copy link
Member

@JunShiozawa Thanks for testing and confirming it works on multiple platforms and browsers.

@akien-mga akien-mga merged commit ece8b38 into godotengine:3.x Jun 25, 2024
14 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants