-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web, 3.x] Add IME input support. #91610
Conversation
Thank you for your backport. 79362_add_ime_input_support_firefox.mp4However, upon confirming the Japanese input with the Enter key, a new line is inserted simultaneously on Safari on macOS. 79362_add_ime_input_support_safari.mp4This could be caused by Safari or Godot; it's not clear which one. |
e02d9f2
to
7ddf27b
Compare
Seems to be something Safari specific, I can't reproduce it in Chrome or Firefox. Also reproducible with Safari and 4.x. |
How can I check if it works? |
@JunShiozawa First, you need to check out this PR. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally?platform=windows |
@akien-mga |
I would kindly ask you to stop lobbying maintainers to work on your personal priorities. We are all busy and doing what we can with the time we have. If you absolutely need this PR today, you can merge it in your own branch and use it, following the documentation that was linked to you above. If you want to help getting this merged, actually testing it and reporting whether it works on all your target browsers would be very helpful. |
@akien-mga |
@JunShiozawa Did you check if it works? |
Where is Export templates? |
This for Godot 4.x Version is |
@JunShiozawa Thanks for testing and confirming it works on multiple platforms and browsers. |
Thanks! |
Backport of #79362 (also include #91695 fixes).