Fix infinite call loop on theme change.

[ajreckof]

Fixes #91553
Based on this comment I had removed updating_theme but it seems it is still necessary even with bulk_theme_override.

[Chaosus]

Works fine but when switching theme not all elements switching correctly (I don't observe that on 4.3 dev 6):

[Chaosus]

Perhaps it would be helpful as a quick fix.

[ajreckof]

Works fine but when switching theme not all elements switching correctly (I don't observe that on 4.3 dev 6):

Not related to the crash but fixed it as it was also introduced by my modification. While testing realized that editorPropertyCategory background is not updated on theme change, tested and it happened even before my modification so left it for later/ maybe there is already a issue / PR for it.

[KoBeWi]

Yeah so the reason this is necessary is that EditorPropertyResource adds theme overrides inside its own NOTIFICATION_THEME_CHANGED and adding overrides will emit that notification again, resulting in infinite recursion.

I don't think it's valid to set theme overrides inside NOTIFICATION_THEME_CHANGED of the same object. The node could connect to theme_changed signal of parent inspector instead, to avoid calling theme changes on itself.

[ajreckof]

I updated it to use the parent theme_changed signal and since it was becoming too big to do separetly on each EditorProperty needing it I implemented it with a simple bool indicating wether it should have borders. it is only implemented to be set at init time. Should I comment on it or should I just make it work at any time with a dedicated setter?

[KoBeWi]

Suggested change

	get_parent()->connect("theme_changed", callable_mp(this, &EditorProperty::_update_property_bg));
	_update_property_bg();
	}
	} break;
	case NOTIFICATION_EXIT_TREE: {
	if (has_borders) {
	get_parent()->disconnect("theme_changed", callable_mp(this, &EditorProperty::_update_property_bg));
	get_parent()->connect(SNAME("theme_changed"), callable_mp(this, &EditorProperty::_update_property_bg));
	_update_property_bg();
	}
	} break;
	case NOTIFICATION_EXIT_TREE: {
	if (has_borders) {
	get_parent()->disconnect(SNAME("theme_changed"), callable_mp(this, &EditorProperty::_update_property_bg));

[AThousandShips]

Or, including scene/scene_string_names.h:

Suggested change

	get_parent()->connect("theme_changed", callable_mp(this, &EditorProperty::_update_property_bg));
	_update_property_bg();
	}
	} break;
	case NOTIFICATION_EXIT_TREE: {
	if (has_borders) {
	get_parent()->disconnect("theme_changed", callable_mp(this, &EditorProperty::_update_property_bg));
	get_parent()->connect(SceneStringName(theme_changed), callable_mp(this, &EditorProperty::_update_property_bg));
	_update_property_bg();
	}
	} break;
	case NOTIFICATION_EXIT_TREE: {
	if (has_borders) {
	get_parent()->disconnect(SceneStringName(theme_changed), callable_mp(this, &EditorProperty::_update_property_bg));

[ajreckof]

I'm assuming this is what you meant as the code you suggested didn't seem to work SceneStringNames::get_singleton()->theme_changed. Please correct me if this was not what you were suggesting.

[AThousandShips]

No I mean exactly what I suggested, it requires a rebase:

• Add shorthand for using singleton string names #81303

[ajreckof]

ok it was merged two hours ago that is why I didn't have it. Thanks for clarifying.

[KoBeWi]

Property backgrounds don't refresh:

[ajreckof]

Fixed thanks

[akien-mga]

Thanks!