Remove error messages caused by Save on Focus feature

[AlexanderFarkas]

Fixes #73765

To clarify: fixing it that way covers most of the problems caused by the underlying issue (showing dialogs on the root Window during notification processing).

Another issue could be created to track the underlying problem.

[Calinou]

Tested locally, it works as expected (Windows 11). I no longer get errors when Save on Focus Loss kicks in.

The downside of this approach is that if saving takes a long time (e.g. due to a huge binary resource being serialized as text in a scene file), the editor will appear to freeze for a few seconds if you alt-tab back in quickly. Still, I consider this is preferable to displaying an error every time the editor loses focus.

Eventually, the scene saving UX should be reworked to use a visually non-blocking method that doesn't need to spawn a dialog. This will alleviate the issue entirely while being less intrusive when you press Ctrl + S or when saving before running a scene.

[AlexanderFarkas]

Tested locally, it works as expected (Windows 11). I no longer get errors when Save on Focus Loss kicks in.

The downside of this approach is that if saving takes a long time (e.g. due to a huge binary resource being serialized as text in a scene file), the editor will appear to freeze for a few seconds if you alt-tab back in quickly. Still, I consider this is preferable to displaying an error every time the editor loses focus.

Eventually, the scene saving UX should be reworked to use a visually non-blocking method that doesn't need to spawn a dialog. This will alleviate the issue entirely while being less intrusive when you press Ctrl + S or when saving before running a scene.

For me the editor freezes even without changes in this PR. It could be especially noticeable when you alt-tab between the editor and the running game. It's probably not related, since alt-tab'ing to the running game always lags for a couple of seconds (even if I don't alt-tab from the editor).

[akien-mga]

Looks good. Could you amend the commit message (with git commit --amend, then git push --force to update the PR) to use a more explicit message?

E.g.:

Remove error messages caused by Save on Focus feature

Fixes #73765.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[AlexanderFarkas]

Awesome!
Thank you for the guidance you have provided me with.
Hope to make another PR soon (at least as a draft) :)