-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FBX: Update ufbx to v0.14.0 #91528
FBX: Update ufbx to v0.14.0 #91528
Conversation
Seems like there's three tasks remaining:
|
The dataset looked fine at a glance, didn't have the time to do a proper labeling this time. The only open issue is the Ready to merge by me. |
I would not support blender pbr since it seems to not handle round tripping well? |
Disabled it for now in that case |
If it's ok can you rebase the pr so it's one commit? |
Could you amend in this documentation change too? diff --git a/thirdparty/README.md b/thirdparty/README.md
index 4a7ab7314a..8c07da5d24 100644
--- a/thirdparty/README.md
+++ b/thirdparty/README.md
@@ -894,7 +894,7 @@ number and run the script.
## ufbx
- Upstream: https://github.com/ufbx/ufbx
-- Version: git (v0.11.1, 2024)
+- Version: 0.14.0 (80ff790ab36507b99ec7e4ef55b9cfb076ce821b, 2024)
- License: MIT
Files extracted from upstream source: |
Sure, thanks! My bad for missing that one, should be fixed now. |
Thanks! |
Update to ufbx to version v0.14.0, which is currently being finished. I'm opening a draft PR to facilitate testing of the new version and so we can discuss a few of the newer features.
Some highlights of the ufbx updates up to v0.13.0:
Fixes from nearly complete v0.14.0, many based on Godot testing (#90986):
UFBX_INHERIT_MODE_HANDLING_COMPENSATE_NO_FALLBACK
to fix some non-scaled inheritance casesTasks for me before I consider this safe for merging: