Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate IMA ADPCM #91492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

DeeJayLSP
Copy link
Contributor

@DeeJayLSP DeeJayLSP commented May 3, 2024

Now that QOA was added as a WAV compression, it makes sense to do this.

This places most of the IMA ADPCM related code into #ifndef DISABLE_DEPRECATED blocks, carefully avoiding compatibility breaks.

  • Trying to load a file and store it as IMA ADPCM will emit a WARN_DEPRECATED_MSG, suggesting to use QOA instead;
  • If the build was compiled with deprecated=no, trying to load and store as IMA ADPCM will throw an error.

Closes godotengine/godot-proposals#4264

@DeeJayLSP DeeJayLSP requested review from a team as code owners December 7, 2024 03:39
@DeeJayLSP
Copy link
Contributor Author

DeeJayLSP commented Dec 7, 2024

Addressing changes from #93831, which moved most of the WAV loading code from ResourceImporterWAV to AudioStreamWAV.

Deprecation should be applied to file loading as well.

@DeeJayLSP DeeJayLSP changed the title Deprecate IMA-ADPCM Deprecate IMA ADPCM Dec 7, 2024
@Repiteo Repiteo modified the milestones: 4.4, 4.x Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate low-quality/limited IMA-ADPCM compression from the WAV importer
4 participants