Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when switching main screen from a disabled plugin main screen if code editor is floating. #91396

Conversation

Daylily-Zeleen
Copy link
Contributor

If currently main screen is provide by editor plugin, remove this editor plugin will switch to script editor automatically.
But the ScriptEditorPlugin will switch to previous editor plugin main screen again if script editor is floating, and lead to crash when switching main screen later.

@akien-mga akien-mga added this to the 4.3 milestone May 1, 2024
@akien-mga akien-mga requested review from a team May 1, 2024 07:52
@akien-mga akien-mga merged commit b297e97 into godotengine:master May 1, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Daylily-Zeleen Daylily-Zeleen deleted the daylily-zeleen/fix_disable_main_screen_plugin_crash branch June 4, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants