Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document 0, 90, 180, and 270 degree TileMap cell rotations #91330

Merged
merged 1 commit into from
May 1, 2024

Conversation

Goldenlion5648
Copy link
Contributor

documents 0, 90, 180, and 270 degree TileMap cell rotations

@Goldenlion5648 Goldenlion5648 requested a review from a team as a code owner April 29, 2024 19:38
@Calinou Calinou added enhancement documentation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 29, 2024
@Calinou Calinou added this to the 4.3 milestone Apr 29, 2024
@mhilbrunner
Copy link
Member

Thanks for contributing :) The commits need to be squashed into one before this can be merged. See here for one explanation on how to do do that.

@Goldenlion5648
Copy link
Contributor Author

Is the job failure due to something on my end? Or is this PR good to go?

Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go to me.

@fire fire changed the title document 0, 90, 180, and 270 degree TileMap cell rotations Document 0, 90, 180, and 270 degree TileMap cell rotations Apr 30, 2024
@akien-mga akien-mga merged commit 9ff72fa into godotengine:master May 1, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Goldenlion5648
Copy link
Contributor Author

Thanks! Will this show up in the current webpage version of the docs when the next minor release for 4.2 comes out? https://docs.godotengine.org/en/4.2/classes/class_tilesetatlassource.html

@akien-mga
Copy link
Member

Yes, after it gets cherry-picked it will be included in the online docs too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants