Fix unsafe uses of Callable.is_null()
#91247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callable.is_null()
is not equivalent to!Callable.is_valid()
and doesn't guarantee the call is valid. It might not cause issues generally but there are cases when this would cause issues, so best to be safe. One major case when this will fail is when the object has been freed.godot/core/variant/callable.h
Lines 90 to 92 in 6118592
godot/core/variant/callable.cpp
Lines 152 to 158 in 6118592