Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Audio Bus button pressed state visibility #91236

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

ckaiser
Copy link
Contributor

@ckaiser ckaiser commented Apr 27, 2024

Light theme audio bus buttons have an issue where I believe thanks to how the icons are loaded, they're much darker by default, which means it's a lot more difficult to modulate them into being bright colors like it would be on dark themes. This caused me (and probably other users, I'm sure) to accidentally click "solo" on a bus and I being unable to figure out why audio wasn't working for a while since at a glance I could not distinguish the button's pressed state.

This PR addresses that by adding a colored underline to the buttons which keeps them as compact as before but allows you to tell at a glance which buses are solo/muted/bypassed.

Before & After comparison:
bus_icons_before_and_after

The worst offender:
imperceptible

@akien-mga
Copy link
Member

I'm not against adding an underline, but I still think the discrepancy between the light and dark themes needs to be fixed properly.

@ckaiser ckaiser force-pushed the audio_bus_contrast branch from b9a5847 to 23e2a6d Compare April 29, 2024 15:12
@ckaiser
Copy link
Contributor Author

ckaiser commented Apr 29, 2024

Adjusted the colors (didn't realize I could just bump it up over 1.0)

New look:
new_after

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The underline helps make it more obvious which buttons are pressed, although we could opt for a translucent background instead (like we do for active buttons in the 2D/3D editor viewport menu bar).

@ckaiser ckaiser force-pushed the audio_bus_contrast branch from 23e2a6d to 0c8ff88 Compare April 29, 2024 21:47
@ckaiser
Copy link
Contributor Author

ckaiser commented Apr 29, 2024

Looks good to me. The underline helps make it more obvious which buttons are pressed, although we could opt for a translucent background instead (like we do for active buttons in the 2D/3D editor viewport menu bar).

I went for the underline because to make a translucent background work I would've had to increase their margins and make everything a bit wider and taller which took away from the compactness of the UI, with this the size remains the same.

Maybe making it a bit chunkier wouldn't be a problem, but this was the least disruptive solution

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 30, 2024
@akien-mga akien-mga merged commit 0af7559 into godotengine:master Apr 30, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants