Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new property named offset_rect to MobileVRInterface #91140

Merged
merged 1 commit into from
May 2, 2024
Merged

Add a new property named offset_rect to MobileVRInterface #91140

merged 1 commit into from
May 2, 2024

Conversation

radiantgurl
Copy link
Contributor

This allows to move around where the screen is actually being rendered, as some mobile VR housings cannot show the full screen of the device due to how big the screens have gotten.

@radiantgurl radiantgurl requested a review from a team as a code owner April 25, 2024 08:50
@akien-mga akien-mga added this to the 4.x milestone Apr 25, 2024
@radiantgurl radiantgurl force-pushed the add-mobile-vr-screen-rect branch from 1b533f5 to 82b4992 Compare April 25, 2024 09:10
BastiaanOlij
BastiaanOlij approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any problems with making this change, it would be good to have some more info in the OP about phones that are effected.

AThousandShips
AThousandShips approved these changes May 2, 2024
View reviewed changes
@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 2, 2024
@radiantgurl radiantgurl force-pushed the add-mobile-vr-screen-rect branch from bcdf532 to ac8df34 Compare May 2, 2024 13:17
@AThousandShips
Copy link
Member

Please update your commit message to be more descriptive, the title of the PR would be fitting

@radiantgurl radiantgurl force-pushed the add-mobile-vr-screen-rect branch from ac8df34 to 9be2f70 Compare May 2, 2024 13:25
@AThousandShips AThousandShips changed the title Implement a new property named offset_rect to MobileVRInterface Add a new property named offset_rect to MobileVRInterface May 2, 2024
@akien-mga akien-mga merged commit 7a968c6 into godotengine:master May 2, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@radiantgurl radiantgurl deleted the add-mobile-vr-screen-rect branch June 15, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
feature proposal topic:xr
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@radiantgurl @AThousandShips @akien-mga @BastiaanOlij