Remove the Hand enum from XRHandTracker #91130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
reviewed
Apr 25, 2024
BastiaanOlij
approved these changes
Apr 25, 2024
fire
approved these changes
Apr 25, 2024
|
Does anyone know why the unit tests are failing? |
It's unrelated. Re-basing on |
|
No rush, but a reminder that the pull request is not able to be merged as is because of failing Github actions. |
Malcolmnixon
force-pushed
the
xrhandtracker-dotnet-name-collision
branch
from
5688cbd to
67f2914
Compare
…e hand property of the base class. Co-Authored-By: David Snopek <[email protected]>
Malcolmnixon
force-pushed
the
xrhandtracker-dotnet-name-collision
branch
from
67f2914 to
e00e5c0
Compare
Rebasing solved the build issue. |
m4gr3d
approved these changes
Apr 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History
When initially introduced for Godot 4.3, the new
XRHandTrackerresource was written with aHandenum [Left=0, Right=1] and ahandproperty describing the hand being tracked.When the XR-Trackers were subsequently reorganized into an inheritance-tree, the
XRHandTrackerwas modified to extend fromXRPositionalTrackerwhich already has ahandproperty [Unknown=0, Left=1, Right=2] relaying identical information.At the time of the XR-Tracker refactoring, the decision was made to keep the
XRHandTracker::Handenum and getter/setter methods, but to drop the property as this was causing a direct name-collision.Problem
What was missed was that for C#/.Net, properties are converted to PascalCase, and so the
XRPositionalTrackerhand property is renamed toHand, causing a direct name collision with theXRHandTracker::Handenum.Change
This PR completely removes the
XRHandTracker::Handenum and getter/setter methods, as they are simply duplicate information for the existingXRPositionalTrackerhand property.The
XRHandTrackertype has not been released yet, and so cleaning it of duplicate/confusing accessors for the same information is preferred - and has the benefit of fixing the C#/.Net name collision.