Fix GDExtension documentation disappearing after hot-reload #91126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
bug
topic:editor
topic:gdextension
cherrypick:4.2
dsnopek
force-pushed
the
fix-gdextension-docs-on-reload
branch
from
3d429d5 to
52324eb
Compare
Riteo
approved these changes
Apr 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76796
Currently, unless a GDExtension provides its own documentation by submitting XML data, its classes will be removed from the editors docs on a successful hot-reload.
This PR fixes that, by re-generating the docs after any extensions have been hot-reloaded.
Works in my testing, both with GDExtensions that provide XML docs data, and those that don't!