Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when moving FileSystem dock #91090

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

timothyqiu
Copy link
Member

Moving the FileSystem dock between different slots produces this error:

ERROR: Signal 'folder_color_changed' is already connected to given callable 'EditorDirDialog::reload' in that object.
at: connect (core/object/object.cpp:1431)

  • For the filesystem_changed signal, it's always connected upon entering the tree and is disconnected when exiting the tree. The redundant connection check is removed.
  • For the folder_color_changed signal, it's the same as filesystem_changed. This PR disconnects it when exiting the tree. So there won't be errors anymore.
  • For the item_collapsed signal, it can be moved to the constructor.

@timothyqiu timothyqiu added this to the 4.3 milestone Apr 24, 2024
@timothyqiu timothyqiu marked this pull request as ready for review April 24, 2024 00:56
@timothyqiu timothyqiu requested review from a team as code owners April 24, 2024 00:56
@akien-mga akien-mga merged commit 2da707e into godotengine:master Apr 24, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the disconnect branch April 24, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants