Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Change default iPad landscape orientation from "left" to "right". #91052

Merged
merged 1 commit into from
May 29, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Apr 23, 2024

Change default landscape orientation from "left" to "right" to match front camera position on 10.gen. iPad.

TODO:

  • None of the other iPads seems to have a front camera on the long side, but the position of the keyboard case attachment should be checked to ensure the "top" side in the landscape orientation is the same (with charging port facing right). Edit: it seems to be the case, at least for all official keyboards.

I'm not sure about iPhone (have not changed it in this PR), currently "Landscape" is camera to the right, charging port to the left.

@bruvzg bruvzg added this to the 4.3 milestone Apr 23, 2024
@bruvzg bruvzg force-pushed the ios_def_landscape branch from 5358820 to 08ab1ff Compare April 23, 2024 10:55
@bruvzg bruvzg marked this pull request as ready for review April 23, 2024 12:29
@bruvzg bruvzg requested review from a team as code owners April 23, 2024 12:29
@aaronfranke
Copy link
Member

On Android, the convention for landscape is that the charging port goes on the right. Based on the iPad photos it looks like Apple is doing the same for the iPad's recommended orientation.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Needs rebase.

@bruvzg bruvzg force-pushed the ios_def_landscape branch from 08ab1ff to c8ae9e9 Compare May 29, 2024 09:49
@akien-mga akien-mga merged commit eb6ab8f into godotengine:master May 29, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants