Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: Have GDScriptWorkspace::list_script_files respect .gdignore. #90949

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

rhofour
Copy link
Contributor

@rhofour rhofour commented Apr 20, 2024

Previously Godot would list and try to load all .gd scripts even if they're in a directory with a .gdignore file.

This was causing me issues because I have some symlinks setup in my repo that meant Godot was accidentally seeing two copies of a bunch of files. This lead to a bunch of errors when every file was loaded twice.

I also changed the formatting slightly to return early if there's an error opening a directory.

@rhofour rhofour requested a review from a team as a code owner April 20, 2024 14:56
@AThousandShips AThousandShips added this to the 4.x milestone Apr 20, 2024
@rhofour
Copy link
Contributor Author

rhofour commented Apr 27, 2024

Poke. Is there anything more I need to do here?

@AThousandShips
Copy link
Member

I'm not sure, it looks right to me but the GDSctipt team would have to give their opinion, probably not as active now on the weekend

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 29, 2024
@akien-mga akien-mga changed the title Have GDScriptWorkspace::list_script_files respect .gdignore. LSP: Have GDScriptWorkspace::list_script_files respect .gdignore. Apr 29, 2024
@akien-mga akien-mga merged commit c33cd94 into godotengine:master Apr 29, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release enhancement topic:gdscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants