Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store TileMapLayer data if empty #90907

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 19, 2024

TileMapLayer will store tile data even if it's empty. When there are no tiles, format version is saved for no reason, leading to potential pointless compatibility problems and documentation noise.

This PR changes it, so with no tiles nothing is saved.

@KoBeWi KoBeWi added this to the 4.3 milestone Apr 19, 2024
@KoBeWi KoBeWi requested review from a team as code owners April 19, 2024 16:08
@akien-mga akien-mga requested a review from groud April 20, 2024 22:56
@akien-mga akien-mga merged commit 7599be9 into godotengine:master Apr 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the null_tile_exception branch April 22, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants