Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Utilize native Variable alias functionality #90857

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Apr 18, 2024

Instead of making platform and p separate variable options, we can instead make use of SCons' native alias functionality by putting both options together in a list. This makes for a slightly prettier --help output & allowed simplifying some selected_platform conditionals.

Before:

platform: Target platform (web|windows)
    default: 
    actual: windows

p: Platform (alias for 'platform')
    default: 
    actual:

After:

platform: Target platform (web|windows)
    default:
    actual: windows
    aliases: ['p']

@Repiteo Repiteo requested a review from a team as a code owner April 18, 2024 14:38
@AThousandShips AThousandShips added this to the 4.x milestone Apr 18, 2024
Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're a SCons wizard :)

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks for looking that up!

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 19, 2024
@akien-mga akien-mga merged commit 462b894 into godotengine:master Apr 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants