Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hidden class in core to replace "EditorX" class being hidden. #90765

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajreckof
Copy link
Member

@ajreckof ajreckof commented Apr 16, 2024

Fixes #88601

This create a way in ClassDB to mark a class as hidden. This value is then used by Create Dialog to skip those class. All Classes that started with Editor were marked as hidden to match previous behavior.
The goal would be to add a similar thing in ScriptServer to enable a @hide annotation to do the same for a script which would help for godotengine/godot-proposals#1047
I would wait for the ScriptServer counterpart which I am already working on before merging because this in fact remove the posibillity to hide nodes even if it was never really considered a feature.

This should make hiding nodes available to GDExtension at least I think.

@RedMser

This comment was marked as outdated.

@ajreckof

This comment was marked as outdated.

@RedMser

This comment was marked as outdated.

@ajreckof

This comment was marked as outdated.

@fire fire changed the title implement hidden class in core to replace "EditorX" class being hidden. Implement hidden class in core to replace "EditorX" class being hidden. Apr 16, 2024
@ajreckof ajreckof marked this pull request as ready for review April 23, 2024 17:25
@ajreckof ajreckof requested review from a team as code owners April 23, 2024 17:25
@raulsntos
Copy link
Member

What's the difference between a hidden class and an internal class? Would it be feasible to use internal classes instead of adding a new kind of class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom class "Editor" can't be added to scene using "Create New Node" dialog.
4 participants