Revert OpenXRHand to its pre-SkeletonModifier3D state
#90759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Apr 16, 2024
TokageItLab
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
For now I approve this, although it is not recommended to keep dangerous Nodes that do not match Godot's architectural design, but during the development and redesign of XRModifier it may be desirable for comparison purposes to have this work.
To prevent users from making new use of deprecated classes in the future, we may want to add an option to hide them from the Node Manager.
akien-mga
approved these changes
Apr 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reverts the changes to
OpenXRHandthat were made in PR #87888I tested it using https://github.com/Malcolmnixon/OpenXRHandTestSuite and everything seemed to work just fine!
This should allow existing projects using
OpenXRHandto continue working without modifications.However, since
OpenXRHandis now deprecated, new projects will be expected to useXRHandModifier3Dinstead, which (after we get all the kinks worked out) will be able to more predictably integrate withAnimationMixers andSkeletonModifier3Ds.Partially addresses issue #90303