Fix incorrect name of internal Basis global scale getter #90748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at the Basis scale methods to double-check that my review of #90584 was correct and I noticed a problem. Basis currently has an internal-only (not exposed) method called
get_scale_local
that gets the global scale.Fortunately the fix is very simple: Rename the method. The 3 places using the method are already correct, they are expecting the global scale as they pass it into
scale
which is global (we could rename this too, although it might be confusing becausescaled
with a "d" is exposed and is also global).Proof: Here is what happens if I expose the method and call it from GDScript:
By the way, if you are wondering whether
from_scale
is global or local, it's actually both. The difference is thatother * from_scale
will perform a local scale, whilefrom_scale * other
will perform a global scale.