Add TextEdit option to prevent copying without a selection #90743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbdev
reviewed
Apr 16, 2024
timothyqiu
force-pushed
the
empty-selection-clipboard
branch
from
c5beb9d to
9b1e1f7
Compare
timothyqiu
force-pushed
the
empty-selection-clipboard
branch
from
9b1e1f7 to
b5a32d3
Compare
kitbdev
reviewed
Sep 13, 2024
Comment on lines
+7009
to
+7232
| if (!empty_selection_clipboard_enabled) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This is probably needed in CodeEdit::_cut_internal as well so it doesn't delete empty lines that aren't copied.
timothyqiu
force-pushed
the
empty-selection-clipboard
branch
from
b5a32d3 to
bf1d06c
Compare
|
Added tests and fixed cut behavior in CodeEdit. |
kitbdev
reviewed
Sep 13, 2024
timothyqiu
force-pushed
the
empty-selection-clipboard
branch
from
bf1d06c to
504e065
Compare
Geometror
approved these changes
Sep 23, 2024
|
Thanks! |
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#9527
Copying current line if nothing is selected is a common code editor feature. But it's usually not expected in normal multiline input boxes. So this behavior should be optional for
TextEdit.This option affects both copying and cutting. Name resembles
editor.emptySelectionClipboardin VS Code.empty_selection_clipboard_enabledtoTextEdit.text_editor/behavior/general/empty_selection_clipboardto Editor Settings.