Fix missing return in StreamPeerTCP::poll when connection is STATUS_CONNECTED
#90741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `StreamPeerTCP` is polled and the TCP connection is `STATUS_CONNECTED` it should return after polling netsocket. Without `return` poll keeps calling `_sock->connect_to_host` and `connect()`.
akien-mga
changed the title
StreamPeerTCP::poll when connection is STATUS_CONNECTED
akien-mga
added
bug
topic:network
cherrypick:4.2
Faless
approved these changes
Apr 16, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
akien-mga
added
the
cherrypick:4.1
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
|
Cherry-picked for 4.1.4. |
akien-mga
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
StreamPeerTCPis polled and the TCP connection isSTATUS_CONNECTEDit should return after polling netsocket for events. Withoutreturnpoll keeps calling_sock->connect_to_hostandconnect(). Callingconnect()on a TCP socket is unspecified behaviour, and likely wrong.