Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picks for the 4.2 branch (future 4.2.2) - 5th batch #90738

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

akien-mga
Copy link
Member

Final_final_v3-final.psd batch for 4.2.2, to fix the critical regression in #89674.

@clayjohn evaluated what's missing from the #87392 cherry-pick, and it turns out we had missed a bunch of follow-up PRs which are also needed to really make headless shader exports reliable, and fix regressions.

The options are to:

So I took the YOLO approach, and while at it, I included the much awaited #90431 which should also be pretty safe, and directly related to these changes. This should make exporting projects on CI much more reliable from 4.2.2 onwards.

Fixes #89674.

Chubercik and others added 6 commits April 16, 2024 08:57
…edCode` and `DefaultIdentifierActions`

(cherry picked from commit b38ac30)
These leaked during tests etc.

(cherry picked from commit 666daf4)
@akien-mga akien-mga merged commit 895f187 into godotengine:4.2 Apr 16, 2024
15 checks passed
@akien-mga akien-mga deleted the 4.2-cherrypicks branch April 16, 2024 08:17
@tokengamedev
Copy link

There was one issue I encountered -
In compatibility mode android x86 and x86_64 simulators were not launching the app. This is of low priority as X86 and x64 devices are almost nonexistent today apart from simulators. I will raise the issue if I find time to test after this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants