Add project setting for root node auto translate mode #90730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Apr 16, 2024
| @@ -1436,6 +1436,10 @@ | |||
| <member name="internationalization/rendering/force_right_to_left_layout_direction" type="bool" setter="" getter="" default="false"> | |||
| Force layout direction and text writing direction to RTL for all controls. | |||
| </member> | |||
| <member name="internationalization/rendering/root_node_auto_translate" type="bool" setter="" getter="" default="true"> | |||
There was a problem hiding this comment.
A "rendering" subsection for this is a bit weird, but it's already what's used for RTL so I agree it's fine to reuse it. Naming things is so hard :D
akien-mga
approved these changes
Apr 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
internationalization/rendering/root_node_auto_translate.Because the root node can't be
AUTO_TRANSLATE_MODE_INHERIT, this setting is just a boolean.