Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Make Streamable option from scene import dialog #90722

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Apr 15, 2024

The option doesn't do anything when enabled, as Godot doesn't have mesh streaming or texture streaming implemented yet.

@Calinou Calinou requested a review from a team as a code owner April 15, 2024 22:07
@Calinou Calinou added this to the 4.3 milestone Apr 15, 2024
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature isn't in so I'm ok hiding it. Does anyone know when it was added. We might have to delete and add back with a new name though. So maybe leave a comment to show it was here.

@fire
Copy link
Member

fire commented Apr 15, 2024

There's also making the option "internal" thus hiding it but avoiding compatibility problems and providing documentation.

@aaronfranke
Copy link
Member

@fire It was added in PR #47166

@akien-mga akien-mga merged commit b9620be into godotengine:master Apr 16, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the import-scene-remove-unused-make-streamable branch April 16, 2024 21:24
@catboy-catfish
Copy link

I thought mesh streaming was already implemented because of LOD support?

@Calinou
Copy link
Member Author

Calinou commented Jul 8, 2024

I thought mesh streaming was already implemented because of LOD support?

For future reference, mesh streaming is not the same as automatic LOD support. When a mesh uses automatic LOD, all its LODs are still present in memory whenever the mesh is loaded. Likewise, if a mesh's LOD is displayed, the full-detail mesh is still stored in memory.

LOD levels also affect the entire mesh at once. It isn't currently possible to have the mesh be split into several smaller parts that can be individually culled or displayed at a different LOD level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants