Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection rect drawing in TileSet editor when create/remove tiles with separation #90709

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Apr 15, 2024

When Ctrl-creating/removing tiles in a TileSetAtlasSource with non-zero separation the selection rect was drawn incorrectly:

Before
(v4.3.dev5.official [89f70e9])
After
(this PR)
AefTjkbi7O RePPyVwGNA

@kleonc kleonc added this to the 4.3 milestone Apr 15, 2024
@akien-mga akien-mga requested review from KoBeWi and groud April 15, 2024 19:16
Copy link
Member

@groud groud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akien-mga akien-mga merged commit 0473f29 into godotengine:master Apr 17, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the tile-set-editor-atlas-with-separation-rect-drawing branch April 17, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants