Fix folder colors not present in editor dir dialog #90651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muller-Castro
force-pushed
the
folder-color
branch
from
88098da to
566dc00
Compare
ajreckof
requested changes
Apr 14, 2024
Muller-Castro
force-pushed
the
folder-color
branch
3 times, most recently
from
6586067 to
d2aa080
Compare
KoBeWi
reviewed
Apr 16, 2024
ajreckof
approved these changes
Apr 16, 2024
Muller-Castro
force-pushed
the
folder-color
branch
from
d2aa080 to
bc62f11
Compare
KoBeWi
reviewed
Apr 16, 2024
KoBeWi
reviewed
Apr 16, 2024
Muller-Castro
force-pushed
the
folder-color
branch
from
bc62f11 to
c8ef9e6
Compare
KoBeWi
reviewed
Apr 16, 2024
| @@ -99,6 +116,8 @@ void EditorDirDialog::reload(const String &p_path) { | |||
| void EditorDirDialog::_notification(int p_what) { | |||
| switch (p_what) { | |||
| case NOTIFICATION_ENTER_TREE: { | |||
| FileSystemDock::get_singleton()->connect("folder_color_changed", callable_mp(this, &EditorDirDialog::reload).bind("")); | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
Unnecessary blank line.
KoBeWi
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90649