Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate the Android debug keystore #90611

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Apr 13, 2024

Automatically generate the Android debug keystore when the Java SDK path is specified.

Fixes https://github.com/godotengine/internal-team-priorities/issues/90

TODO:

  • Test on Linux
  • Test on MacOs
  • Test on Windows
  • Remove the Create a debug.keystore section from the documentation when this is merged.

Automatically generate the Android debug keystore when the Java SDK path is specified.
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 13, 2024

Seems to work as expected on Linux, MacOs and Windows! I'd appreciate more testing but for now we can remove the needs testing tag.

@akien-mga akien-mga self-requested a review April 13, 2024 14:36
@melquiadess
Copy link
Contributor

Looks great. and works for me too (Windows 11), with these steps:

  • go to Editor -> Editor Settings
  • make sure Java SDK Path is set
  • go to Debug Keystore path in File Explorer, delete the debug key, if there is one
  • back to Godot -> force any setting change notification, eg. delete the path to Debug Keystore
  • wait a second
  • the key is autogenerated, Debug Keystore path updated
  • and exporting for Android works fine afterwards
  • ...
  • delete the key again, and delete Java SDK Path, and Debug Keystore -> they key is not autogenerated (because it needs Java SDK Path setup)
  • but restore Java SDK Path - and the key gets generated again 👍
autogenerate-debug-key-test.mp4

@akien-mga akien-mga merged commit e500046 into godotengine:master Apr 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants