GridMap: Fix physics_material property
#90503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use computed bounce and friction, just like StaticBody3D already does. Also don't rebuild all internals just to set two floats on each body.
smix8
approved these changes
Apr 10, 2024
|
Reminds me that having a single physics material for the entire GridMap was a not very sound decision. Should have been really a property of the item. |
|
@smix8 At least the property is called It would be possible to add a per-item override. (I would wait for someone to propose it.) Another idea I heard was making physics materials per-shape, but that's more involved. (The per-GridMap-item override could be implemented either way.) |
akien-mga
approved these changes
Apr 10, 2024
|
Thanks! |
|
Thanks for the quick work on this, it will make a big impact on my current project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use computed bounce and friction, just like
StaticBody3Dalready does.Also don't rebuild all internals just to set two floats on each body.