Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface normals are not the same thing as collision normals for move_and_slide() #90460

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Gamepro5
Copy link
Contributor

For both CharacterBody3D and CharacterBody2D. Godot does not currently support surface normals.

I forgot to that it applies to walls and CharacterBody2D when I made #90254 .

I still don't understand how to rebase, but this time I didn't make the edits from the GitHub website.

@Gamepro5 Gamepro5 requested a review from a team as a code owner April 10, 2024 02:49
@akien-mga akien-mga added this to the 4.3 milestone Apr 10, 2024
@akien-mga akien-mga requested a review from a team April 10, 2024 06:26
@mhilbrunner
Copy link
Member

Looks good to me. On rebasing, this whole document is worth a read, and has a section on it:

https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html

@akien-mga akien-mga merged commit fa11643 into godotengine:master Apr 10, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Gamepro5
Copy link
Contributor Author

Looks good to me. On rebasing, this whole document is worth a read, and has a section on it:

https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html

@mhilbrunner I know, I've read it multiple times. I use GitHub desktop for everything and it does not use the command line. I forked with the GitHub website and cloned with desktop. I then committed via desktop and made the PR on the website. Is there not a way to rebase with the GUI? If not, I'll only use the command line moving forward and the docs would make sense then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants