Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to copy absolute path in file system dock popup #90421

Conversation

Krigu
Copy link
Contributor

@Krigu Krigu commented Apr 9, 2024

This is the implementation of the proposal 7521 - Add "Copy Absolute Path" to filesystem folders

The PR adds a new entry in the file system popup which adds the option to copy the absolute path of a folder or a file. This simplifies the workflow when opening assets from godot projects with third-party apps.

screenshot_copy_absolute_path

@timothyqiu
Copy link
Member

I prefer not setting an icon for this menu item.

  • So that this menu feels less crowded.
  • It's the same as "Copy Path", but much less used.

@Krigu
Copy link
Contributor Author

Krigu commented Apr 9, 2024

I updated the PR and removed the icon as suggested by @timothyqiu

copy_absolute_path_no_icon

@Krigu Krigu force-pushed the add_option_copy_absolute_path_to_file_system_dock_popup branch from 933e103 to 5c1d1ea Compare April 9, 2024 20:05
@Krigu Krigu marked this pull request as ready for review April 10, 2024 06:53
@Krigu Krigu requested a review from a team as a code owner April 10, 2024 06:53
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 10, 2024
@akien-mga akien-mga merged commit 7d7d303 into godotengine:master Apr 10, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Copy Absolute Path" to filesystem folders
5 participants