Use likely() in PtrToArg<T *> when checking for null Object *s
#90394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduz
approved these changes
Apr 29, 2024
Naros
approved these changes
Apr 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In godotengine/godot-cpp#1405, @reduz requested that
likely()be added toPtrToArg<T *>when checking for nullObject *s in godot-cpp.This is doing the same thing for the equivalent code in Godot, so that we are consistent between Godot and godot-cpp.
I also switched to using a ternary to match the godot-cpp code. I'd be fine going the other way and switching godot-cpp to use an
if-statement, but however we do it, it'd be nice to be somewhat consistent. (Unfortunately, the casts can't be made consistent due to other differences.)