Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Support all possible suffixes for console wrapper #90387

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Apr 8, 2024

The official builds use _console.exe but the custom built version use .console.exe, this adds support for both, otherwise you can't export with the wrapper automatically added if you use a custom build directly, a bit hacky perhaps but I think it's better than changing the build format

Edit: Added support for all the suffixes supported by the console wrapper itself

@AThousandShips AThousandShips requested a review from a team April 8, 2024 14:06
@bruvzg
Copy link
Member

bruvzg commented Apr 8, 2024

For the reference, the wrapper itself also supports space and no separator.

static PCWSTR exe_renames[] = {

@AThousandShips
Copy link
Member Author

Will add a list of cases instead and include all four and do a simple loop over them

@AThousandShips AThousandShips changed the title [Windows] Support both underscore and period in wrapper [Windows] Support all possible suffixes for wrapper Apr 8, 2024
@AThousandShips AThousandShips changed the title [Windows] Support all possible suffixes for wrapper [Windows] Support all possible suffixes for console wrapper Apr 8, 2024
@akien-mga akien-mga merged commit d2c7f09 into godotengine:master Apr 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the console_wrap_fix branch April 8, 2024 20:57
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants