Fix strange visual bug with camera and external change. #90317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajreckof
force-pushed
the
Fix-strange-visual-bug-with-camera-and-external-change-
branch
from
5de4ee9 to
cc2d162
Compare
ajreckof
force-pushed
the
Fix-strange-visual-bug-with-camera-and-external-change-
branch
from
cc2d162 to
609559c
Compare
KoBeWi
approved these changes
Apr 8, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90301
Sincerely I don't know what was happening with this bug but it was because check and update was called later then before. So I reverted this change but had to defer the connection to the
set_edited_sceneas it needs the scene it replace to be the currently edited one. Moreover since the actual replace in editor_data is only happening later I had to defer the deletion of the old root hence thequeue_free.Edit : realised it was misbehaving with selection so I had to tweak it a bit more for selection to be properly kept